ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398006947
##########
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##########
@@ -1038,13 +1038,15 @@ public void
shouldThrowConfigExceptionWhenOptimizationConfigNotValueInRange() {
assertThrows(ConfigException.class, () -> new StreamsConfig(props));
}
+ @SuppressWarnings("deprecation")
@Test
public void shouldSpecifyRocksdbWhenNotExplicitlyAddedToConfigs() {
final String expectedDefaultStoreType = StreamsConfig.ROCKS_DB;
final String actualDefaultStoreType =
streamsConfig.getString(DEFAULT_DSL_STORE_CONFIG);
assertEquals("default.dsl.store should be \"rocksDB\"",
expectedDefaultStoreType, actualDefaultStoreType);
}
+ @SuppressWarnings("deprecation")
@Test
public void shouldSpecifyInMemoryWhenExplicitlyAddedToConfigs() {
Review Comment:
Can you add some basic tests for the new store config? Basically something
like what we have for the old configs -- ie the default is rocksdb and that
the built-in InMemoryDslStoreSuppliers -- but instead of the bad-enum one, just
make sure you can actually pass in a custom implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
