agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398269890
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreFactory.java:
##########
@@ -66,6 +66,10 @@ default void configure(final StreamsConfig config) {
boolean isVersionedStore();
+ // TODO: consider moving all the log configuration code
(InternalTopicConfig)
Review Comment:
> Just wondering, would we also be able to get rid of the #historyRetention
and #isVersionedStore or is that used for something else?
we would with a little bit more abstraction/refactoring. they are used
somewhere to check configurations but I think it makes sense to push that into
this class as well and get rid of that too.
> Btw unless you plan on doing it yourself in an immediate followup PR
I am happy to do that, I checked the code and found quite a few TODOs so I
assumed it was OK. I'll just remove the TODO and file a JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
