dajac commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399512038
##########
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##########
@@ -267,56 +267,106 @@ class GroupCoordinatorBaseRequestTest(cluster:
ClusterInstance) {
val syncGroupRequest = new
SyncGroupRequest.Builder(syncGroupRequestData).build()
val syncGroupResponse =
connectAndReceive[SyncGroupResponse](syncGroupRequest)
assertEquals(expectedError.code, syncGroupResponse.data.errorCode)
+
+ syncGroupResponse.data
}
- protected def joinConsumerGroupWithOldProtocol(
+ protected def sendJoinRequest(
groupId: String,
+ memberId: String = "",
+ groupInstanceId: String = null,
+ protocolType: String = "consumer",
+ protocolName: String = "consumer-range",
metadata: Array[Byte] = Array.empty,
- assignment: Array[Byte] = Array.empty,
- completeRebalance: Boolean = true
- ): (String, Int) = {
+ version: Option[Short] = None
Review Comment:
nit: How about not using an Option here and using the latest version as the
default value? This would also simplify the logic later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
