dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399513759


##########
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##########
@@ -146,37 +145,33 @@ class HeartbeatRequestTest(cluster: ClusterInstance) 
extends GroupCoordinatorBas
         metadata = metadata
       )
 
-      val reJoinFollowerFuture = Future {
+      Future {

Review Comment:
   Hmm, I tried to remove this but it doesn't work. Unless we return a future 
in sendJoinRequest so the future is needed anyway



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to