agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399930568
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java:
##########
@@ -91,11 +91,13 @@ private KeyValueStore<Bytes, byte[]> maybeWrapLogging(final
KeyValueStore<Bytes,
}
private final static class InMemoryTimestampedKeyValueStoreMarker
+ extends WrappedStateStore<KeyValueStore<Bytes, byte[]>, Bytes, byte[]>
Review Comment:
yes it was, we needed it in order to pass the tests that I added which check
that `InMemoryXStore` is in the store heirarchy - otherwise it would stop at
this change
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java:
##########
@@ -91,11 +91,13 @@ private KeyValueStore<Bytes, byte[]> maybeWrapLogging(final
KeyValueStore<Bytes,
}
private final static class InMemoryTimestampedKeyValueStoreMarker
+ extends WrappedStateStore<KeyValueStore<Bytes, byte[]>, Bytes, byte[]>
Review Comment:
yes it was, we needed it in order to pass the tests that I added which check
that `InMemoryXStore` is in the store heirarchy - otherwise it would stop at
this level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
