agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399939069
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedInternal.java:
##########
@@ -18,16 +18,30 @@
package org.apache.kafka.streams.kstream.internals;
import org.apache.kafka.common.serialization.Serde;
+import org.apache.kafka.streams.TopologyConfig;
import org.apache.kafka.streams.kstream.StreamJoined;
+import org.apache.kafka.streams.state.DslStoreSuppliers;
import org.apache.kafka.streams.state.WindowBytesStoreSupplier;
import java.util.Map;
public class StreamJoinedInternal<K, V1, V2> extends StreamJoined<K, V1, V2> {
+ private final InternalStreamsBuilder builder;
+
//Needs to be public for testing
- public StreamJoinedInternal(final StreamJoined<K, V1, V2> streamJoined) {
+ public StreamJoinedInternal(
+ final StreamJoined<K, V1, V2> streamJoined,
+ final InternalStreamsBuilder builder
+ ) {
super(streamJoined);
+ this.builder = builder;
+ if (dslStoreSuppliers == null) {
+ final TopologyConfig topologyConfig =
builder.internalTopologyBuilder.topologyConfigs();
+ if (topologyConfig != null) {
+ dslStoreSuppliers =
topologyConfig.resolveDslStoreSuppliers().orElse(null);
+ }
Review Comment:
nice catch! added a test and fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
