mjsax commented on code in PR #14768:
URL: https://github.com/apache/kafka/pull/14768#discussion_r1402777990
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java:
##########
@@ -150,11 +150,9 @@ public class LegacyKafkaConsumer<K, V> implements
ConsumerDelegate<K, V> {
LogContext logContext = createLogContext(config,
groupRebalanceConfig);
this.log = logContext.logger(getClass());
boolean enableAutoCommit =
config.getBoolean(ENABLE_AUTO_COMMIT_CONFIG);
- groupId.ifPresent(groupIdStr -> {
- if (groupIdStr.isEmpty()) {
- log.warn("Support for using the empty group id by
consumers is deprecated and will be removed in the next major release.");
- }
- });
+
+ if (this.groupId.isPresent() && this.groupId.get().isEmpty())
+ throw new InvalidGroupIdException("The configured group.id
should not be an empty string or whitespace");
Review Comment:
I don't think we can make this change in a minor release, but we need to
wait for 4.0. It's break compatibility, and we are not allowed to break it in a
minor release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
