cmccabe commented on code in PR #14820:
URL: https://github.com/apache/kafka/pull/14820#discussion_r1406858333
##########
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##########
@@ -405,7 +415,7 @@ private void completeReassignmentIfNeeded() {
targetAdding = Collections.emptyList();
}
- public Optional<ApiMessageAndVersion> build() {
+ public Optional<ApiMessageAndVersion> build(DefaultDirProvider
defaultDirProvider) {
Review Comment:
Please don't add arguments to build(). If you want to have a way to set the
default directory, then have a `Builder.setDefaultDirProvider` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
