soarez commented on code in PR #14820: URL: https://github.com/apache/kafka/pull/14820#discussion_r1406913694
########## metadata/src/main/java/org/apache/kafka/metadata/placement/DefaultDirProvider.java: ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.metadata.placement; + +import org.apache.kafka.common.Uuid; + +/** + * Provide the default directory for new partitions in a given broker. + */ +@FunctionalInterface +public interface DefaultDirProvider { + Uuid defaultDir(int brokerId); Review Comment: I'll add documentation. But I don't think this should ever return `MIGRATING`, we simply do not call this provider unless the MetadataVersion supports direcotry assignments. The other result this might have is the single dir for a broker that supports JBOD but is registered with a single directory. Essentially this is so we can preset directory assignment to the only registered directory in a broker for new partitions or reassignments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
