AndrewJSchofield commented on PR #14835: URL: https://github.com/apache/kafka/pull/14835#issuecomment-1829545443
> Thanks for the PR! prod code looks good to me, I just added three minor things that I spotted while going through the code. However, I have two requests: > Can we add a test to check that we are interrupting the wait correctly in poll? I could imagine if we mock timeUntilNextPoll it shouldn't be too difficult. Certainly. I'll do it. > It seems we are solving two things in this PR - correctly build the heartbeat (only send the diff) and the fix to not miss something. We don't need to split the PR, but could you update the PR description? Yes, I'll do that. We just needed both things to make the `kafka-console-consumer.sh` tool correctly join a stable group and start receiving records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
