jeffkbkim commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1408056685
##########
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##########
@@ -55,17 +56,21 @@ class CoordinatorLoaderImpl[T](
* Loads the coordinator by reading all the records from the TopicPartition
* and applying them to the Replayable object.
*
- * @param tp The TopicPartition to read from.
- * @param coordinator The object to apply records to.
+ * @param tp The TopicPartition to read from.
+ * @param coordinator The object to apply records to.
+ * @param onLoadedBatch Invoked when a batch was successfully
loaded.
+ * @param onHighWatermarkUpdated Invoked when the high watermark advanced.
*/
override def load(
tp: TopicPartition,
- coordinator: CoordinatorPlayback[T]
+ coordinator: CoordinatorPlayback[T],
+ onLoadedBatch: Consumer[java.lang.Long],
+ onHighWatermarkUpdated: Consumer[java.lang.Long]
Review Comment:
i did not like the fact that we need to have a replay() method in both
CoordinatorPlayback and CoordinatorShard. we cannot move replay() to just
CoordinatorContext because it needs to access OffsetMetadataManager and
GroupMetadataManager.
If you think that is fine, then I can make the changes. Is it not a good
practice to use consumers like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
