dajac commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1409237609
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorPlayback.java:
##########
@@ -33,4 +33,18 @@ public interface CoordinatorPlayback<U> {
* @throws RuntimeException if the record can not be applied.
*/
void replay(U record) throws RuntimeException;
+
+ /**
+ * Invoke operations when a batch has been successfully loaded.
+ *
+ * @param offset the offset of the last record in the batch.
+ */
+ void onBatchLoaded(Long offset);
Review Comment:
Should we align the naming on the method that we have in the coordinator
context? It is kind of confusing if we use different terms here, I think.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorPlayback.java:
##########
@@ -33,4 +33,18 @@ public interface CoordinatorPlayback<U> {
* @throws RuntimeException if the record can not be applied.
*/
void replay(U record) throws RuntimeException;
+
+ /**
+ * Invoke operations when a batch has been successfully loaded.
+ *
+ * @param offset the offset of the last record in the batch.
+ */
+ void onBatchLoaded(Long offset);
+
+ /**
+ * Called when the high watermark advances.
+ *
+ * @param highWatermark the new high watermark.
+ */
+ void onHighWatermarkUpdated(Long highWatermark);
Review Comment:
Same question here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
