cadonna commented on code in PR #14872:
URL: https://github.com/apache/kafka/pull/14872#discussion_r1409848052
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -398,6 +387,38 @@ public class AsyncKafkaConsumer<K, V> implements
ConsumerDelegate<K, V> {
requestManagersSupplier);
}
+ private Optional<ConsumerGroupMetadata> initializeGroupMetadata(final
ConsumerConfig config,
+ final
GroupRebalanceConfig groupRebalanceConfig) {
+ final Optional<ConsumerGroupMetadata> groupMetadata =
initializeGroupMetadata(
+ groupRebalanceConfig.groupId,
+ groupRebalanceConfig.groupInstanceId
+ );
+ if (!groupMetadata.isPresent()) {
+ config.ignore(ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG);
+ config.ignore(THROW_ON_FETCH_STABLE_OFFSET_UNSUPPORTED);
+ }
+ return groupMetadata;
+ }
+
+ private Optional<ConsumerGroupMetadata> initializeGroupMetadata(final
String groupId,
+ final
Optional<String> groupInstanceId) {
+ if (groupId != null) {
+ if (groupId.isEmpty()) {
Review Comment:
I think moving forward when we will also change the validation of the group
ID for the legacy consumer in 4.0 we should write a validator for the group ID
config in `ConsumerConfig` throw there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
