cadonna commented on code in PR #14872: URL: https://github.com/apache/kafka/pull/14872#discussion_r1409850375
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ########## @@ -752,6 +757,70 @@ public void testSubscriptionOnEmptyTopic() { assertThrows(IllegalArgumentException.class, () -> consumer.subscribe(singletonList(emptyTopic))); } + @Test Review Comment: I put the tests here because they do only apply to the async consumer for the moment. As I wrote in a different comment, moving forward, we should move this tests to the `ConsumerConfig`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org