junrao commented on code in PR #14767: URL: https://github.com/apache/kafka/pull/14767#discussion_r1410140939
########## core/src/main/scala/kafka/server/KafkaApis.scala: ########## @@ -3697,16 +3698,60 @@ class KafkaApis(val requestChannel: RequestChannel, CompletableFuture.completedFuture[Unit](()) } - // Just a place holder for now. def handleGetTelemetrySubscriptionsRequest(request: RequestChannel.Request): Unit = { - requestHelper.sendMaybeThrottle(request, request.body[GetTelemetrySubscriptionsRequest].getErrorResponse(Errors.UNSUPPORTED_VERSION.exception)) - CompletableFuture.completedFuture[Unit](()) + val subscriptionRequest = request.body[GetTelemetrySubscriptionsRequest] + + if (ClientMetricsReceiverPlugin.instance.isEmpty) { + info("Received get telemetry client request, no metrics receiver plugin configured or running with ZK") + requestHelper.sendResponseMaybeThrottle(request, requestThrottleMs => + subscriptionRequest.getErrorResponse(requestThrottleMs, Errors.UNSUPPORTED_VERSION.exception)) Review Comment: @apoorvmittal10 : ApiVersionResponse is defined to include all new types of requests supported on the server. So, there is no need to have a separate KIP. There is no need to add clientTelemetryEnabled in ApiVersionResponse. If clientTelemetryEnabled is false on the server, we can just exclude telemetry related API keys from ApiVersionResponse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org