aliehsaeedii commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1411947974
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##########
@@ -136,11 +139,11 @@ public long put(final Bytes key, final byte[] value,
final long timestamp) {
observedStreamTime = Math.max(observedStreamTime, timestamp);
final long foundTs = doPut(
- versionedStoreClient,
- observedStreamTime,
- key,
- value,
- timestamp
+ versionedStoreClient,
Review Comment:
> nit: avoid unnecessary reformation / intention changes -- similar below.
>
> 80% of diff in this file is just adding/removing spaces... very noisy
Sorry, resolving the conflicts made a total mess!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
