aliehsaeedii commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1411961568
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##########
@@ -266,75 +269,28 @@ public VersionedRecord<byte[]> get(final Bytes key, final
long asOfTimestamp) {
return null;
}
- public VersionedRecordIterator<byte[]> get(final Bytes key, final long
fromTimestamp, final long toTimestamp, final boolean isAscending) {
-
- Objects.requireNonNull(key, "key cannot be null");
+ @SuppressWarnings("unchecked")
Review Comment:
> Why do we need this suppression?
Because of the following warning when creating a `LogicalSegmentIterator`
object ([line#
280](https://github.com/aliehsaeedii/kafka/blob/30f8d197319359074924b25041f63387484dbc08/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java#L280),
and [line#
293](https://github.com/aliehsaeedii/kafka/blob/30f8d197319359074924b25041f63387484dbc08/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java#L293))
`Unchecked assignment:
'org.apache.kafka.streams.state.internals.LogicalSegmentIterator' to
'org.apache.kafka.streams.state.VersionedRecordIterator<byte[]>' `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
