lucasbru commented on code in PR #14878:
URL: https://github.com/apache/kafka/pull/14878#discussion_r1413549969
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -783,6 +774,7 @@ void markReconciliationCompleted() {
* </ol>
*/
private void resolveMetadataForUnresolvedAssignment() {
+ assignmentReadyToReconcile.clear();
Review Comment:
It's the integration test in this PR `testRemoteAssignorRange`.
The problem is that we are getting 6 partitions from a HB, we add them to
`assignmentReadyToReconcile`, next heart-beat we get only 4 partitions, we also
add them to `assignmentReadyToReconcile`, but the 2 partitions that were
supposed to be removed are never removed because they are still in
`assignmentReadyToReconcile`.
If we get `assignmentReadyToReconcile` updated only from two places, can we
just remove everything here that is not part of the new assignment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
