lianetm commented on code in PR #14878:
URL: https://github.com/apache/kafka/pull/14878#discussion_r1414016456
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -783,6 +774,7 @@ void markReconciliationCompleted() {
* </ol>
*/
private void resolveMetadataForUnresolvedAssignment() {
+ assignmentReadyToReconcile.clear();
Review Comment:
Oh I see, and agree that we do need the fix (but it was not in
https://github.com/apache/kafka/commit/21edb7078814e5cac41051b170b3ed5ecf4057d5,
only partly). I was missing the fact that the topics that we may discovered in
metadata at any time will be as also included in the new assignments received
(if there are still assigned). Basically the same principle that the broker is
the source of truth regarding assignment. @lucasbru if you can let the fix in
with the test that would be great (or I could just add it in another PR if you
prefer). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
