gharris1727 commented on code in PR #14293:
URL: https://github.com/apache/kafka/pull/14293#discussion_r1414605900
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##########
@@ -314,6 +356,23 @@ private <T extends SourceConnector> void
awaitConnectorTasksStart(final MirrorMa
}, MM_START_UP_TIMEOUT_MS, "Tasks for connector " +
clazz.getSimpleName() + " for MirrorMaker instances did not transition to
running in time");
}
+ private <T extends SourceConnector> void
awaitConnectorConfiguration(MirrorMaker mm, Class<T> clazz, SourceAndTarget
sourceAndTarget, Predicate<Map<String, String>> predicate) throws
InterruptedException {
+ String connName = clazz.getSimpleName();
+ waitForCondition(() -> {
+ try {
+ FutureCallback<Map<ConnectorTaskId, Map<String, String>>> cb =
new FutureCallback<>();
+ herder(mm, sourceAndTarget).tasksConfig(connName, cb);
Review Comment:
I think I was doing a sort of "end-to-end-test" that verified that both the
new configuration got applied to the connector, and that internal forwarding
took place for the task configurations. I realize now that the method name
doesn't match this implementation, so i renamed it to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
