C0urante commented on code in PR #14293:
URL: https://github.com/apache/kafka/pull/14293#discussion_r1416019825
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##########
@@ -314,6 +356,23 @@ private <T extends SourceConnector> void
awaitConnectorTasksStart(final MirrorMa
}, MM_START_UP_TIMEOUT_MS, "Tasks for connector " +
clazz.getSimpleName() + " for MirrorMaker instances did not transition to
running in time");
}
+ private <T extends SourceConnector> void
awaitConnectorConfiguration(MirrorMaker mm, Class<T> clazz, SourceAndTarget
sourceAndTarget, Predicate<Map<String, String>> predicate) throws
InterruptedException {
+ String connName = clazz.getSimpleName();
+ waitForCondition(() -> {
+ try {
+ FutureCallback<Map<ConnectorTaskId, Map<String, String>>> cb =
new FutureCallback<>();
+ herder(mm, sourceAndTarget).tasksConfig(connName, cb);
Review Comment:
Ah, very nice. Good call on end-to-end testing 👍
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##########
@@ -314,6 +356,23 @@ private <T extends SourceConnector> void
awaitConnectorTasksStart(final MirrorMa
}, MM_START_UP_TIMEOUT_MS, "Tasks for connector " +
clazz.getSimpleName() + " for MirrorMaker instances did not transition to
running in time");
}
+ private <T extends SourceConnector> void
awaitConnectorConfiguration(MirrorMaker mm, Class<T> clazz, SourceAndTarget
sourceAndTarget, Predicate<Map<String, String>> predicate) throws
InterruptedException {
+ String connName = clazz.getSimpleName();
+ waitForCondition(() -> {
+ try {
+ FutureCallback<Map<ConnectorTaskId, Map<String, String>>> cb =
new FutureCallback<>();
+ herder(mm, sourceAndTarget).tasksConfig(connName, cb);
Review Comment:
Ah, very nice. Good call on end-to-end testing 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
