kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1414752935
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -183,6 +183,10 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
return new
NetworkClientDelegate.PollResult(heartbeatRequestState.heartbeatIntervalMs,
Collections.singletonList(request));
}
+ public MembershipManager membershipManager() {
+ return membershipManager;
+ }
Review Comment:
It's for access by the `ApplicationEventProcessor` to process its events
that relate to the state machine.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerRebalanceListenerInvoker.java:
##########
@@ -66,15 +66,15 @@ Exception invokePartitionsAssigned(final
SortedSet<TopicPartition> assignedParti
throw e;
} catch (Exception e) {
log.error("User provided listener {} failed on invocation of
onPartitionsAssigned for partitions {}",
- listener.getClass().getName(), assignedPartitions, e);
+ listener.get().getClass().getName(),
assignedPartitions, e);
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
