dajac commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1418643128
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.clients.consumer.internals.events; + +import org.apache.kafka.clients.consumer.Consumer; +import org.apache.kafka.clients.consumer.ConsumerRebalanceListener; +import org.apache.kafka.clients.consumer.internals.ConsumerRebalanceListenerMethodName; +import org.apache.kafka.common.TopicPartition; + +import java.time.Duration; +import java.util.Collections; +import java.util.Objects; +import java.util.SortedSet; + +/** + * Event that signifies that the network I/O thread wants to invoke one of the callback methods on the + * {@link ConsumerRebalanceListener}. This event will be processed by the application thread when the next + * {@link Consumer#poll(Duration)} call is performed by the user. When processed, the application thread should + * invoke the appropriate callback method (based on {@link #methodName()}) with the given partitions. + */ +public class ConsumerRebalanceListenerCallbackNeededEvent extends BackgroundEvent { + + private final ConsumerRebalanceListenerMethodName methodName; + private final SortedSet<TopicPartition> partitions; + + public ConsumerRebalanceListenerCallbackNeededEvent(ConsumerRebalanceListenerMethodName methodName, Review Comment: Let me try to re-explain. At the moment, the state machine sends an event for the `onRevoked` callback, waits for its completion, sends an event for the `onAssigned` callback, and waits for its completion. @lianetm and I thought that we should change this to actually trigger them together with a single event in order to reduce the dependency on the foreground thread. This is not done yet but @lianetm will eventually get to this. With this in mind, I was wondering if we could have already implemented the `ConsumerRebalanceListenerCallbackNeededEvent` in a way which will support this. Otherwise, she will have to refactor it later on. Basically, `ConsumerRebalanceListenerCallbackNeededEvent` would need to support calling both `onRevoke` and `onAssigned`, still one after another in the foreground thread but within a single event. @lianetm Would it help you if we do it here or are you fine with refactoring this later on? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
