lianetm commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1420570473
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -587,6 +599,18 @@ public boolean shouldSkipHeartbeat() {
return state == MemberState.UNSUBSCRIBED || state == MemberState.FATAL;
}
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public void transitionToStaled() {
+ transitionTo(MemberState.PREPARE_LEAVING);
Review Comment:
Looks to me this is not really needed here? We use this state when we are
taking some action before sending the last HB (mainly callbacks), but in this
case there is no async operation to do, just send the last HB right? which is
explicitly done in the HB mgr when checking that the poll timer expired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
