cadonna commented on code in PR #15004:
URL: https://github.com/apache/kafka/pull/15004#discussion_r1426360971
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -401,7 +401,18 @@ private void replaceUnresolvedAssignmentWithNewAssignment(
*/
@Override
public void transitionToFenced() {
Review Comment:
nit:
It is kind of weird that a method named `transitionToFenced()` transits to
other states than `FENCED`. I think the name of this method should rather be
`handleFenced()` or similar. That would contribute to code readability because
it distinguishes between handling a `FENCED` error and transiting to the
`FENCED` state which apparently is not the same thing.
You do not need to change anything, my intention with this comment is merely
food for thoughts. You can change it in a future PR if you agree with me.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -593,6 +604,11 @@ private void transitionToSendingLeaveGroup() {
"FATAL state", memberId, memberEpoch);
return;
}
+ if (state == MemberState.UNSUBSCRIBED) {
+ log.warn("Member {} won't send leave group request because it is
already out of the group.",
Review Comment:
Why is this a warning? Wouldn't an info be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
