lianetm commented on code in PR #14557:
URL: https://github.com/apache/kafka/pull/14557#discussion_r1426846736
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -429,21 +492,40 @@ public void onResponse(final ClientResponse response) {
long offset = offsetAndMetadata.offset();
Errors error = Errors.forCode(partition.errorCode());
if (error == Errors.NONE) {
- log.debug("OffsetCommit {} for partition {}", offset,
tp);
+ log.debug("OffsetCommit completed successfully for
offset {} partition {}", offset, tp);
continue;
}
- if (error == Errors.TOPIC_AUTHORIZATION_FAILED) {
+ if (error == Errors.COORDINATOR_NOT_AVAILABLE ||
Review Comment:
I changed it to simplify it, because the previous `CommitReqMgr` had
specific logic(ifs) for multiple errors, that truly did not need any specific
action (other than failing the future and logging).
Now we do have specific actions for the errors that need it (like the
coordinator ones), but the ones that only need to log and fail go to a [single
place](https://github.com/apache/kafka/blob/b7eb1081cd2d7546c47ed549ea4881b51ef96fec/clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java#L531)
where we use the `error.exception` and `error.message`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
