dajac commented on code in PR #14557:
URL: https://github.com/apache/kafka/pull/14557#discussion_r1426753201
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -625,7 +627,9 @@ public void commitAsync(Map<TopicPartition,
OffsetAndMetadata> offsets, OffsetCo
}
// Visible for testing
- CompletableFuture<Void> commit(final Map<TopicPartition,
OffsetAndMetadata> offsets, final boolean isWakeupable) {
+ CompletableFuture<Void> commit(final Map<TopicPartition,
OffsetAndMetadata> offsets,
+ final boolean isWakeupable,
+ final Optional<Long> timeoutMs) {
Review Comment:
This param is a bit subtile because it means two things: 1) retry and 2) the
max duration. It is not obvious when you read it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
