vamossagar12 commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1436578781
##########
connect/api/src/main/java/org/apache/kafka/connect/data/SchemaProjector.java:
##########
@@ -37,13 +37,13 @@
public class SchemaProjector {
- private static Set<AbstractMap.SimpleImmutableEntry<Type, Type>>
promotable = new HashSet<>();
+ private static final Set<AbstractMap.SimpleImmutableEntry<Type, Type>>
PROMOTABLE = new HashSet<>();
Review Comment:
nit: We should probably call out that the casing of variable(s) has been
changed in the PR description? Currently it only says the usage of `final`..
##########
connect/api/src/main/java/org/apache/kafka/connect/data/SchemaProjector.java:
##########
@@ -37,13 +37,13 @@
public class SchemaProjector {
- private static Set<AbstractMap.SimpleImmutableEntry<Type, Type>>
promotable = new HashSet<>();
+ private static final Set<AbstractMap.SimpleImmutableEntry<Type, Type>>
PROMOTABLE = new HashSet<>();
Review Comment:
Also, wondering if this change got imposed due to a checkstyle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
