mimaison commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1442700296
##########
clients/src/main/java/org/apache/kafka/common/record/LazyDownConversionRecordsSend.java:
##########
@@ -36,9 +36,9 @@ public final class LazyDownConversionRecordsSend extends
RecordsSend<LazyDownCon
private static final int MAX_READ_SIZE = 128 * 1024;
static final int MIN_OVERFLOW_MESSAGE_LENGTH = Records.LOG_OVERHEAD;
- private RecordValidationStats recordValidationStats;
+ private final RecordValidationStats recordValidationStats;
private RecordsSend convertedRecordsWriter;
- private Iterator<ConvertedRecords<?>> convertedRecordsIterator;
+ private final Iterator<ConvertedRecords<?>> convertedRecordsIterator;
Review Comment:
We can swap this line with the one above to group all final fields
##########
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/StandardAuthorizerUpdateBenchmark.java:
##########
@@ -59,17 +59,15 @@
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public class StandardAuthorizerUpdateBenchmark {
- @Param({"25000", "50000", "75000", "100000"})
- private int aclCount;
+ private static final Random RANDOM = new
Random(System.currentTimeMillis());
private final String resourceNamePrefix = "foo-bar35_resource-";
Review Comment:
Can we move this field down?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java:
##########
@@ -64,11 +64,11 @@ public class MockConsumer<K, V> implements Consumer<K, V> {
private final Map<TopicPartition, OffsetAndMetadata> committed;
private final Queue<Runnable> pollTasks;
private final Set<TopicPartition> paused;
+ private final AtomicBoolean wakeup;
- private Map<TopicPartition, List<ConsumerRecord<K, V>>> records;
+ private final Map<TopicPartition, List<ConsumerRecord<K, V>>> records;
Review Comment:
Let's add the empty line after this field to separate the final fields from
the other ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
