jolshan commented on code in PR #15086:
URL: https://github.com/apache/kafka/pull/15086#discussion_r1439990671
##########
core/src/test/scala/integration/kafka/api/GroupCoordinatorIntegrationTest.scala:
##########
@@ -33,18 +34,21 @@ class GroupCoordinatorIntegrationTest extends
KafkaServerTestHarness {
overridingProps.put(KafkaConfig.OffsetsTopicPartitionsProp, "1")
overridingProps.put(KafkaConfig.OffsetsTopicCompressionCodecProp,
offsetsTopicCompressionCodec.id.toString)
- override def generateConfigs = TestUtils.createBrokerConfigs(1, zkConnect,
enableControlledShutdown = false).map {
+ override def generateConfigs = TestUtils.createBrokerConfigs(1,
zkConnectOrNull, enableControlledShutdown = false).map {
KafkaConfig.fromProps(_, overridingProps)
}
- @Test
- def testGroupCoordinatorPropagatesOffsetsTopicCompressionCodec(): Unit = {
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testGroupCoordinatorPropagatesOffsetsTopicCompressionCodec(quorum:
String): Unit = {
val consumer = TestUtils.createConsumer(bootstrapServers())
val offsetMap = Map(
new TopicPartition(Topic.GROUP_METADATA_TOPIC_NAME, 0) -> new
OffsetAndMetadata(10, "")
).asJava
consumer.commitSync(offsetMap)
- val logManager = servers.head.getLogManager
+ val logManager =
+ if (isKRaftTest()) brokers.head.logManager
Review Comment:
Can we use brokers.head.logManager for Zk tests too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
