artemlivshits commented on code in PR #15139:
URL: https://github.com/apache/kafka/pull/15139#discussion_r1443564382
##########
metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java:
##########
@@ -27,21 +27,24 @@
public final class LocalReplicaChanges {
private final Set<TopicPartition> deletes;
- private final Map<TopicPartition, PartitionInfo> leaders;
+ private final Map<TopicPartition, PartitionInfo> electedLeaders;
+ private final Map<TopicPartition, PartitionInfo> updatedLeaders;
Review Comment:
`updatedLeaders` have the info that has semantics similar to `followers`
(something updated in the partition where the broker is the leader or a
follower), so we should probably have names to be similar. E.g. both should be
`updated*` or both should have no prefix (then electedLeaders should probably
be newLeaders or newlyElectedLeaders).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
