jolshan commented on code in PR #15139:
URL: https://github.com/apache/kafka/pull/15139#discussion_r1446488616
##########
metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java:
##########
@@ -27,21 +27,24 @@
public final class LocalReplicaChanges {
private final Set<TopicPartition> deletes;
- private final Map<TopicPartition, PartitionInfo> leaders;
+ private final Map<TopicPartition, PartitionInfo> electedLeaders;
+ private final Map<TopicPartition, PartitionInfo> updatedLeaders;
Review Comment:
I included these comments btw:
```
* 1. partitions for which the broker is not a replica anymore
* 2. partitions for which the broker is now a leader (leader epoch
bump on the leader)
* 3. partitions for which the isr or replicas change if the broker is
a leader (partition epoch bump on the leader)
* 4. partitions for which the broker is now a follower or follower
with isr or replica updates (partition epoch bump on follower)
```
I really struggled with the name "leaders" when i was reading the code which
is why i didn't want to leave it blank. But I will think on it again an update
the comments to be even more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
