jolshan commented on code in PR #15139:
URL: https://github.com/apache/kafka/pull/15139#discussion_r1451051792
##########
checkstyle/suppressions.xml:
##########
@@ -315,7 +315,7 @@
<suppress checks="(ParameterNumber|ClassDataAbstractionCoupling)"
files="(QuorumController).java"/>
<suppress checks="(CyclomaticComplexity|NPathComplexity)"
- files="(PartitionRegistration|PartitionChangeBuilder).java"/>
+
files="(PartitionRegistration|PartitionChangeBuilder|TopicDelta).java"/>
Review Comment:
In between when I wrote this originally and now a lot of JBOD code was
added. I don't think I have the skills to make it simpler. I don't think there
is a way to change my code. I can use the annotation if you think that keeps
the suppression more contained
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
