dajac commented on code in PR #15221:
URL: https://github.com/apache/kafka/pull/15221#discussion_r1462855794
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##########
@@ -501,13 +521,11 @@ public void testOffsetDeleteWith(
final
OffsetDeleteResponseData.OffsetDeleteResponsePartitionCollection
expectedResponsePartitionCollection =
new
OffsetDeleteResponseData.OffsetDeleteResponsePartitionCollection();
- if (hasOffset(groupId, topic, partition)) {
Review Comment:
This was actually wrong. The response should contain an entry for a
partition even if the partition had no offset. See
https://github.com/apache/kafka/pull/15221/files#diff-a4ad0e0a77c78dde2a841d055dd64e15f7da00b8a2a9e3279d74b718d5c612bbR607.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
