jolshan commented on code in PR #15221:
URL: https://github.com/apache/kafka/pull/15221#discussion_r1464175850
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##########
@@ -2342,26 +2375,24 @@ public void testConsumerGroupOffsetDeleteWithErrors() {
context.testOffsetDeleteWith("foo", "bar", 0,
Errors.GROUP_SUBSCRIBED_TO_TOPIC);
}
+ @Test
+ public void testConsumerGroupOffsetDeleteWithPendingTransactionalOffsets()
{
+ OffsetMetadataManagerTestContext context = new
OffsetMetadataManagerTestContext.Builder().build();
+ ConsumerGroup group =
context.groupMetadataManager.getOrMaybeCreateConsumerGroup(
+ "foo",
+ true
+ );
+ context.commitOffset(10L, "foo", "bar", 0, 100L, 0,
context.time.milliseconds());
+ assertFalse(group.isSubscribedToTopic("bar"));
+ context.testOffsetDeleteWith("foo", "bar", 0, Errors.NONE);
Review Comment:
do we want to test if the offset is deleted here like for the generic group?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
