divijvaidya commented on code in PR #15239:
URL: https://github.com/apache/kafka/pull/15239#discussion_r1463080761


##########
build.gradle:
##########
@@ -2286,8 +2286,9 @@ project(':streams:streams-scala') {
     api project(':streams')
 
     api libs.scalaLibrary
-    api libs.scalaCollectionCompat
-
+    if ( versions.baseScala == '2.12' ) {
+      api libs.scalaCollectionCompat

Review Comment:
   Can you please add a comment here explaining the reason for this removal of 
dependency, basically, capture what you wrote in PR here. It helps the readers 
of the code understand why certain actions were taken.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to