lianetm commented on code in PR #15202:
URL: https://github.com/apache/kafka/pull/15202#discussion_r1463366293
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -536,12 +543,23 @@ public void onResponse(final ClientResponse response) {
continue;
}
- if (error == Errors.COORDINATOR_NOT_AVAILABLE ||
+ if (error == Errors.GROUP_AUTHORIZATION_FAILED) {
+
future.completeExceptionally(GroupAuthorizationException.forGroupId(groupId));
+ return;
+ } else if (error == Errors.COORDINATOR_NOT_AVAILABLE ||
error == Errors.NOT_COORDINATOR ||
error == Errors.REQUEST_TIMED_OUT) {
coordinatorRequestManager.markCoordinatorUnknown(error.message(),
currentTimeMs);
maybeRetry(currentTimeMs, error.exception());
return;
+ } else if (error == Errors.FENCED_INSTANCE_ID) {
+ log.info("OffsetCommit failed due to group instance id
{} fenced: {}", groupInstanceId, error.message());
+ future.completeExceptionally(new
CommitFailedException());
Review Comment:
uhm I had addressed it by adding `log.error` instead of `log.info`, but
maybe I misunderstood your comment. Were you suggesting something different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
