lianetm commented on code in PR #15202:
URL: https://github.com/apache/kafka/pull/15202#discussion_r1463496440
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -414,8 +495,69 @@ public void testOffsetFetchRequestErroredRequests(final
Errors error, final bool
testNonRetriable(futures);
assertEmptyPendingRequests(commitRequestManger);
}
+ }
- assertCoordinatorDisconnect(error);
+ @Test
Review Comment:
Sure, done for this and other similar cases that could be parametrized (That
was the approach, not even sure why I did not use them in these)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
