fvaleri commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1471706683
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -500,6 +553,34 @@ public static Map<String, ConfigKey> configKeys() {
return Collections.unmodifiableMap(CONFIG.configKeys());
}
+ public List<String> logDirs() {
+ String csvList = logDirs != null ? logDirs : logDir;
+ if (csvList == null || csvList.isEmpty()) {
+ return Collections.emptyList();
+ } else {
+ return Arrays.stream(csvList.split("\\s*,\\s*"))
+ .filter(v -> !v.equals(""))
+ .collect(Collectors.toList());
+ }
+ }
+
+ public String getMetadataLogDir() {
+ if (metadataLogDir != null) {
+ return metadataLogDir;
+ } else {
+ return logDirs().get(0);
+ }
+ }
+
+ public Optional<String> interBrokerProtocolVersion() {
+ String originalIBP = (String)
originals().get(LogConfig.INTER_BROKER_PROTOCOL_VERSION_PROP);
+ return originalIBP != null ? Optional.of(originalIBP) :
Optional.empty();
+ }
+
+ public Boolean unstableMetadataVersionsEnabled() {
+ return unstableMetadataVersionsEnabled;
+ }
Review Comment:
They are used by the tool, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
