fvaleri commented on code in PR #15273:
URL: https://github.com/apache/kafka/pull/15273#discussion_r1471706520
##########
raft/src/main/java/org/apache/kafka/raft/RaftConfig.java:
##########
@@ -206,6 +245,27 @@ private static Integer parseVoterId(String idString) {
}
}
+ private static Set<String> parseProcessRoles(List<String> processRoles,
Map<Integer, AddressSpec> voterConnections, int nodeId) {
Review Comment:
KafkaConfig:1537, I kept the original code here. I don't remember the exact
reason, as two months have passed.
I have to move ProcessRole from server to server-common to avoid circular
dependency. Let me know if this is fine.
##########
raft/src/main/java/org/apache/kafka/raft/RaftConfig.java:
##########
@@ -206,6 +245,27 @@ private static Integer parseVoterId(String idString) {
}
}
+ private static Set<String> parseProcessRoles(List<String> processRoles,
Map<Integer, AddressSpec> voterConnections, int nodeId) {
Review Comment:
KafkaConfig:1537, I kept the original code here. I don't remember the exact
reason, as two months have passed. I have to move ProcessRole from server to
server-common to avoid circular dependency. Let me know if this is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
