gharris1727 commented on code in PR #15302:
URL: https://github.com/apache/kafka/pull/15302#discussion_r1478735608
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##########
@@ -801,6 +806,11 @@ public void testResetSinkConnectorOffsetsZombieSinkTasks()
throws Exception {
connect.assertions().assertConnectorAndAtLeastNumTasksAreRunning(connectorName,
1,
"Connector tasks did not start in time.");
+ // Make sure the tasks' consumers have had a chance to actually form a
group
+ // (otherwise, the reset request will succeed because there won't be
any active consumers)
+ verifyExpectedSinkConnectorOffsets(connectorName, topic, 1,
NUM_RECORDS_PER_PARTITION,
Review Comment:
And since this commit no longer changes the behavior of the Reset test, does
that mean that KAFKA-15224 is not addressed in this commit? Is that flaky
failure still possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
