dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492567552
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ########## @@ -346,10 +346,9 @@ public static Record newCurrentAssignmentRecord( new ConsumerGroupCurrentMemberAssignmentValue() .setMemberEpoch(member.memberEpoch()) .setPreviousMemberEpoch(member.previousMemberEpoch()) - .setTargetMemberEpoch(member.targetMemberEpoch()) + .setState(member.state().value()) Review Comment: It was mainly used to determine whether a new assignment was required if its target epoch was stale. The state with the previous schema was basically determined by the target member epoch, the partitions pending revocation and the partitions pending assignment. It was a bit weakly defined. Having a proper state seems much better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org