dajac commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1492574501
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##########
@@ -779,7 +779,7 @@ private void maybeUpdateGroupState() {
newState = ASSIGNING;
} else {
for (ConsumerGroupMember member : members.values()) {
- if (member.targetMemberEpoch() != targetAssignmentEpoch.get()
|| member.state() != ConsumerGroupMember.MemberState.STABLE) {
+ if (!member.isReconciledTo(targetAssignmentEpoch.get())) {
Review Comment:
The member epoch has not changed. A member is fully reconciled when it is
Stable in the latest epoch (targetAssignmentEpoch). The previous condition was
a bit weird, I agree.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java:
##########
@@ -369,20 +329,12 @@ public String toString() {
/**
* The partitions being revoked by this member.
*/
- private final Map<Uuid, Set<Integer>> partitionsPendingRevocation;
-
- /**
- * The partitions waiting to be assigned to this
- * member. They will be assigned when they are
- * released by their previous owners.
- */
- private final Map<Uuid, Set<Integer>> partitionsPendingAssignment;
+ private final Map<Uuid, Set<Integer>> revokedPartitions;
Review Comment:
Nope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
