florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1493064669
########## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java: ########## @@ -816,10 +816,12 @@ public void testWindowing() { stream1 = builder.stream(topic1, consumed); stream2 = builder.stream(topic2, consumed); + final Duration timeDifference = ofMillis(100L); + final Duration grace = ofMillis(104); Review Comment: On second thought, note my coment below on 'Why + 1 '. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org