junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1498439741
##########
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##########
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+ // Visible for testing
+ final class ClientMetricsStats {
+
+ private static final String GROUP_NAME = "ClientMetrics";
+
+ // Visible for testing
+ static final String INSTANCE_COUNT = "ClientMetricsInstanceCount";
Review Comment:
So far, the naming convention for Kafka metrics is to use hyphen. So,
ClientMetricsInstanceCount should be client-metrics-instance-count. Ditto
below. Since the code hasn't been released yet. Could we make the change and
update the KIP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
