junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1500047932
##########
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##########
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+ // Visible for testing
+ final class ClientMetricsStats {
+
+ private static final String GROUP_NAME = "ClientMetrics";
+
+ // Visible for testing
+ static final String INSTANCE_COUNT = "ClientMetricsInstanceCount";
Review Comment:
@apoorvmittal10 : On the server side, we have been using both Yammer metrics
(org.apache.kafka.server.metrics.KafkaMetricsGroup) and Kafka metrics
(org.apache.kafka.common.metrics.Metrics). The convention is that for the
former, we use camel case. For the latter, we use hyphen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
