[
https://issues.apache.org/jira/browse/KAFKA-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548106#comment-16548106
]
ASF GitHub Bot commented on KAFKA-7180:
---------------------------------------
gitlw opened a new pull request #5387: KAFKA-7180: Fixing the flaky test
testHWCheckpointWithFailuresSingleLogSegment
URL: https://github.com/apache/kafka/pull/5387
By waiting until server1 has joined the ISR before shutting down server2
Rerun the test method many times after the code change, and there is no
flakiness any more.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> In testHWCheckpointWithFailuresSingleLogSegment, wait until server1 has
> joined the ISR before shutting down server2
> -------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-7180
> URL: https://issues.apache.org/jira/browse/KAFKA-7180
> Project: Kafka
> Issue Type: Bug
> Reporter: Lucas Wang
> Assignee: Lucas Wang
> Priority: Minor
>
> In the testHWCheckpointWithFailuresSingleLogSegment method, the test logic is
> 1. shutdown server1 and then capture the leadership of a partition in the
> variable "leader", which should be server2
> 2. shutdown server2 and wait until the leadership has changed to a broker
> other than server2
> through the line
> waitUntilLeaderIsElectedOrChanged(zkClient, topic, partitionId, oldLeaderOpt
> = Some(leader))
> However when we execute step 2 and shutdown server2, it's possible that
> server1 has not caught up with the partition, and has not joined the ISR.
> With unclean leader election turned off, the leadership cannot be transferred
> to server1, causing the waited condition in step 2 to be never met.
> The obvious fix is to wait until server1 has joined the ISR before shutting
> down server2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
