soarez commented on code in PR #15451:
URL: https://github.com/apache/kafka/pull/15451#discussion_r1509037381


##########
tests/kafkatest/tests/core/kraft_upgrade_test.py:
##########
@@ -108,6 +108,27 @@ def run_upgrade(self, from_kafka_version):
         assert len(cluster_id) == 22
         assert self.kafka.check_protocol_errors(self)
 
+        # Ensure we can create another topic and produce/consume to/from it
+        new_topic_cfg = {
+            "topic": "test-topic-2",
+            "partitions": self.partitions,
+            "replication-factor": self.replication_factor,
+            "configs": {"min.insync.replicas": 2}

Review Comment:
   Don't we want to consider `self.replication_factor` here? Maybe `min(2, 
self.replication_factor)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to