cadonna commented on code in PR #15455: URL: https://github.com/apache/kafka/pull/15455#discussion_r1511735767
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ########## @@ -177,7 +177,7 @@ private void process(final FetchCommittedOffsetsEvent event) { return; } CommitRequestManager manager = requestManagers.commitRequestManager.get(); - long expirationTimeMs = getExpirationTimeForTimeout(event.timeout()); + long expirationTimeMs = getExpirationTimeForTimeout(event.deadlineMs()); Review Comment: Wait, I think we are misunderstanding each other. Method `getExpirationTimeForTimeout()` computes a point in time by adding a given timeout, i.e., a time delta, to the the current time. Method `event.deadlineMS()` returns a point in time computed by adding the remaining time of the timer, i.e., a time delta, to the current time. With this call you are trying to compute a point in time by adding a time point to the current time. This does not look like a limitation but rather like a mistake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org