kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1513515432
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##########
@@ -29,10 +30,19 @@ public abstract class CommitEvent extends
CompletableApplicationEvent<Void> {
*/
private final Map<TopicPartition, OffsetAndMetadata> offsets;
- protected CommitEvent(final Type type, final Map<TopicPartition,
OffsetAndMetadata> offsets) {
- super(type);
+ protected CommitEvent(final Type type, final Map<TopicPartition,
OffsetAndMetadata> offsets, final Timer timer) {
+ super(type, timer);
this.offsets = Collections.unmodifiableMap(offsets);
+ validate(this.offsets);
+ }
+
+ protected CommitEvent(final Type type, final Map<TopicPartition,
OffsetAndMetadata> offsets, final long timer) {
Review Comment:
Thanks for catching that, @cadonna! I renamed it to `deadlineMs` for
consistency with the rest of the variable/parameter names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
